Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bug fixes #134

Closed
wants to merge 14 commits into from
Closed

Several bug fixes #134

wants to merge 14 commits into from

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented May 11, 2016 •
edited
Loading

Fixes #133 and #146.

@deivid-rodriguez deivid-rodriguez mentioned this pull request May 11, 2016
Closed
@deivid-rodriguez
Copy link
Contributor Author

@mivok Could you review this and, if possible, release a version with the latest fixes? Thanks a lot!!

@deivid-rodriguez
Copy link
Contributor Author

@mivok ping

@deivid-rodriguez
Copy link
Contributor Author

@mivok Here it goes, my monthly ping! ;)

@deivid-rodriguez
Copy link
Contributor Author

@mivok ⏰ ping!

@deivid-rodriguez
Copy link
Contributor Author

@mivok I'd like to contribute a bit more to this repo (I just run into #146 and I want to fix it), but I'd like to know whether this is on your radar or not first.

David Rodríguez added 14 commits August 20, 2016 18:57
Move helper methods to private section
fac8845 
And leave only actual tests as public methods.
Move "bundle exec" to run_cli
a9115c4
Renaming to make it simpler
cbebe86
Extract a run_cli_with_input method
1b6ff9c 
To avoid having to pass a lot of dummy parameters, harming readability.
Extract another utility method for tests
38677b7
Fix encoding issue with unicode characters
abfa25f
Allow configuring path to rc file in tests
b38ddbe
Consistent spacing
627d75d 
The rest of the method is separated into "comment + commented lines"
blocks with blank lines. Do it here as well.
Extract some duplicated code into a method
a786215
Isolate rc loading tests to a temp folder
5d0e9b1 
This way we are sure we never affect "real" rc files.
Fixes #133
2f3aef8
Remove ancient rubies from Travis matrix
e723f57
Add modern rubies to Travis matrix
64c561b
Remove redundant quotes from Travis matrix
2ef4124
@deivid-rodriguez
Copy link
Contributor Author

Including both fixes here #133 and #146, so I can easily use this branch.

@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 20, 2016
Closed
@deivid-rodriguez deivid-rodriguez changed the title Fixes #133 Several bug fixes Aug 20, 2016
@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 21, 2016
Merged
@deivid-rodriguez
Copy link
Contributor Author

Superseded by #148

@deivid-rodriguez deivid-rodriguez deleted the issue_133 branch August 21, 2016 01:36
@mivok
Copy link
Collaborator

mivok commented Aug 21, 2016

Hi David,

As you've no doubt noticed, I've been extremely busy over the past couple of months and had essentially no time to work on markdownlint. As a result I've been pretty quiet here, and for that I'd like to apologize. I'll spend some time over the next day or so to review your fixes in #148 (and other open PRs too) and get them merged in.

@deivid-rodriguez
Copy link
Contributor Author

No problem, I understand! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deivid-rodriguez @mivok