Allow "changelog-style" header organization #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psyomn Ping! |
|
I'm going to try and get back to you tonight, it's been busy on my end.
Sorry.
…On Sun, May 20, 2018 at 11:37 AM, David Rodríguez ***@***.***> wrote:
@psyomn <https://github.com/psyomn> Ping!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#200 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAe3WJaDWyx_qs159lVeihy7EwtHNUU7ks5t0Y2tgaJpZM4TztYm>
.
|
|
Welp, newer version seems to be working :). |
|
Yeah! :) |
deivid-rodriguez
force-pushed
the
fix/allow_different_nesting_on_headers_duplication_check
branch
from
01e9a25
to
6e2c161
Compare
|
Alright will merge if you have no objections! |
|
I just wonder about the default. As it is now, it's backwards incompatible... Should probably be switched to |
|
I think it would be maybe a better idea to have it as |
|
Yeah, I was having the same thought. I'll flip the default and pick you back when ready. Thanks @psyomn! |
|
No prob! Thanks, and sorry for taking so long |
|
@psyomn It's done! |
No worries, I know what it's like, and it hasn't been that long :) |
|
Sweet thanks a lot man! |
deivid-rodriguez
deleted the
fix/allow_different_nesting_on_headers_duplication_check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175.
I chose to add this as a style (although I made it the default, not sure about that), because the original check can still be useful for some people.
Can styles be configured on a per-file basis, by the way?