Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent, but blockquoted, list items are valid #284

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

cpb
Copy link
Contributor

@cpb cpb commented Nov 17, 2019

Description

Adds test coverage and patches the MarkdownLint::Doc#list_style method to identify the style of blockquoted list items.

Adds test coverage and patches the MD030 rule to handle blockquoted examples for MD004.

Related Issues

#261

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Documentation (non-breaking change that does not add functionality but updates documentation)
- [ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • Wrote good commit messages
  • Feature branch is up-to-date with master, if not - rebase it
  • Added tests for all new/changed functionality, including tests for positive and negative scenarios
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

@cpb
Copy link
Contributor Author

cpb commented Nov 19, 2019

@jaymzh What do you think of this PR?

I believe @gorge511 @valsr endorsed #261 ... maybe they could see if this PR works for them?

@jaymzh
Copy link
Member

jaymzh commented Nov 21, 2019

I'll have a look this weekend.

@cpb
Copy link
Contributor Author

cpb commented Nov 21, 2019 via email

Copy link
Member

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaymzh jaymzh merged commit b3ce720 into markdownlint:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants