Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON gem dependency error when using '--json' option with docker #409

Merged
merged 1 commit into from Jan 14, 2022
Merged

Fix JSON gem dependency error when using '--json' option with docker #409

merged 1 commit into from Jan 14, 2022

Conversation

orviz
Copy link
Contributor

@orviz orviz commented Jan 14, 2022 •
edited

Description

This PR resolves the issue in the docker image when JSON output is requested.

Related Issues

Closes #408

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-breaking change that does not add functionality but updates documentation)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • Wrote good commit messages
  • Feature branch is up-to-date with master, if not - rebase it
  • Added tests for all new/changed functionality, including tests for positive and negative scenarios
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

@orviz
Fix JSON gem dependency error when using '--json' option with docker (m…
0f2147f 
…arkdownlint#408)

By installing Alpine's 'ruby-full' package, all the MDL dependencies with the
ruby standard library are resolved (including not only 'json', but also 'etc'
gems).

Signed-off-by: Pablo Orviz <orviz@ifca.unican.es>
jaymzh
jaymzh approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaymzh jaymzh merged commit b72d180 into markdownlint:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image fails when using -j (--json) option
2 participants
@orviz @jaymzh