Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown lint version in SARIF output test #469

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

mathroule
Copy link
Contributor

Description

SARIF output in test fixtures contains hardcoded Markdown lint version. Bumping Markdown lint version makes the test fails.

Related Issues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-breaking change that does not add functionality but updates documentation)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • Wrote good commit messages
  • Feature branch is up-to-date with main, if not - rebase it
  • Added tests for all new/changed functionality, including tests for positive and negative scenarios
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

Signed-off-by: Mathieu Rul <mathroule@gmail.com>
Signed-off-by: Mathieu Rul <mathroule@gmail.com>
@mathroule mathroule mentioned this pull request Oct 2, 2023
10 tasks
Copy link
Member

@jaymzh jaymzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaymzh jaymzh merged commit d22747e into markdownlint:main Oct 2, 2023
5 of 6 checks passed
@mathroule mathroule deleted the bugfix/fix-sarif-output-test branch October 2, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants