Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank lines with spaces can render unexpected setext headers #2708

Closed
jldec opened this issue Jan 15, 2023 · 0 comments · Fixed by #2986
Closed

Blank lines with spaces can render unexpected setext headers #2708

jldec opened this issue Jan 15, 2023 · 0 comments · Fixed by #2986
Labels
category: headings L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@jldec
Copy link

jldec commented Jan 15, 2023

Marked version:
4.2.3 and later

Describe the bug
According to commonmark setext headers should be generated when text is not interrupted by a blank line.

Since marked v4.2.3, lines containing one or more spaces are not being treated as blank lines in setext headers. This causes surprising H1 anc H2 headings where there should be paragraphs.

To Reproduce
v4.2.2 works
v4.2.3 and later - surprise 😮
commonmark confirmed

Expected behavior
Match behavior of commonmark setext headers.

@UziTech UziTech added L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue category: headings labels Jan 15, 2023
znicholasbrown added a commit to PrefectHQ/prefect-design that referenced this issue Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: headings L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants