Provide anchors with headings if Github flowered markdown

[Swaagie]

fixes #89

I'd really like to fix some of the tests that will be broken now. However, I fail to see an easy way to turn on/off several options, like gfm. It would be best add some tests without gfm and patch up the 5 that will break as result of this change.

[lepture]

@Swaagie This could be easily customized with renderer feature, which I provided at #129 .

[Swaagie]

I agree that would be a nice addition, currently just went with the default rendering of github. You can do a lot with some CSS and an empty anchor. But I guess some people would rather have id's on headings or perhaps an alternative inline element. I'll try to bug @chjj on IRC to review this stuff.

[xixixao]

Note that including .s and :s will break CSS selecting.

[Swaagie]

how does this break selecting? link is only used as href and name

[xixixao]

Some (bootstrap's scrollspy for example) might want to select elements like this: a[href=the-converted-id]

viz. http://stackoverflow.com/a/72577, also a bit surprisingly, name is supposed to be deprecated: http://www.w3schools.com/tags/att_a_name.asp

[Swaagie]

I can see this being the case for general use cases, however this
addition is specifically tailored to Github Flavored Markdown, and as
such following their conventions. Also note that it's using the heading
text not the id. I can see the scrollspy working like this, but if I'm
missing something tell me please

On 03/27/2013 06:40 PM, Michal Srb wrote:

In lib/marked.js:

@@ -820,9 +820,22 @@ Parser.prototype.tok = function() {
return '

---

\n';
}
case 'heading': {

•  var internal = '';
  

•  if (this.options.gfm) {
  

•    var link = this.token.text
  

•      .toLowerCase()
  

•      .replace(/\s/g, '-')
  

•      .replace(/[^a-z0-9-_:.]/g, '');
  

Some (bootstrap's scrollspy for example) might want to select elements
like this: a[href=the-converted-id]

—
Reply to this email directly or view it on GitHub
https://github.com/chjj/marked/pull/131/files#r3555907.

[micky2be]

looking forward to see that PR merged

[chjj]

Closed in favor of #181.