Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --save option as it isn't required anymore #1422

Merged
merged 2 commits into from Feb 19, 2019

Conversation

@stevemoser
Copy link
Contributor

commented Feb 18, 2019

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

"As of npm 5.0.0, installed modules are added as a dependency by default, so the --save option is no longer needed. The other save options still exist and are listed in the documentation for npm install."

https://stackoverflow.com/a/19578808/142358

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • [x ] no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

stevemoser added some commits Feb 18, 2019

@styfle

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@stevemoser Thanks for the contribution!

I think it is a little more clear with --save (as opposed to --save-dev) and works with npm older than a year (npm 5 wasn't released until May 2017).


@UziTech What do you think?

@UziTech

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

I'm good either way. Since the docs are for beginners, it seems like keeping it simple would be best.

@styfle

styfle approved these changes Feb 19, 2019

Copy link
Member

left a comment

👌

@styfle styfle merged commit f42c4a7 into markedjs:master Feb 19, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.