Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1823 - task lists are rendered even when GFM is disabled #1825

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Fix #1823 - task lists are rendered even when GFM is disabled #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c95191
Fix #1823 - task lists are rendered even when GFM is disabled.
TheCloudlessSky Nov 15, 2020
b319fbb
end file with a new line
UziTech Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,11 +278,13 @@ module.exports = class Tokenizer {
}

// Check for task list items
istask = /^\[[ xX]\] /.test(item);
ischecked = undefined;
if (istask) {
ischecked = item[1] !== ' ';
item = item.replace(/^\[[ xX]\] +/, '');
if (this.options.gfm) {
istask = /^\[[ xX]\] /.test(item);
ischecked = undefined;
if (istask) {
ischecked = item[1] !== ' ';
item = item.replace(/^\[[ xX]\] +/, '');
}
}

list.items.push({
Expand Down
5 changes: 5 additions & 0 deletions test/specs/new/list_tasks_non_gfm.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<ul>
<li>[ ] A</li>
<li>[x] B</li>
<li>[ ] C</li>
</ul>
7 changes: 7 additions & 0 deletions test/specs/new/list_tasks_non_gfm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
gfm: false
description: Task lists are ignored when not using GFM
---
- [ ] A
- [x] B
- [ ] C