Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop table at lines with only whitespace #2188

Merged
merged 3 commits into from Aug 25, 2021
Merged

fix: stop table at lines with only whitespace #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab9027f
add test
UziTech Aug 25, 2021
bcb059f
fix table regex to stop at lines with only whitespace
UziTech Aug 25, 2021
5a2eda4
lint
UziTech Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules.js
View file
Open in desktop
Expand Up @@ -93,7 +93,7 @@ block.normal = merge({}, block);
block.gfm = merge({}, block.normal, {
table: '^ *([^\\n ].*\\|.*)\\n' // Header
+ ' {0,3}(?:\\| *)?(:?-+:? *(?:\\| *:?-+:? *)*)\\|?' // Align
+ '(?:\\n *((?:(?!\\n|hr|heading|blockquote|code|fences|list|html).*(?:\\n|$))*)\\n*|$)' // Cells
+ '(?:\\n((?:(?! *\\n|hr|heading|blockquote|code|fences|list|html).*(?:\\n|$))*)\\n*|$)' // Cells
});

block.gfm.table = edit(block.gfm.table)
Expand Down
16 changes: 16 additions & 0 deletions test/specs/new/space_after_table.html
View file
Open in desktop
@@ -0,0 +1,16 @@
<table>
<thead>
<tr>
<th>a</th>
<th>b</th>
</tr>
</thead>
<tbody>
<tr>
<td>1</td>
<td>2</td>
</tr>
</tbody>
</table>

<p>there should be a single space in the line above</p>
8 changes: 8 additions & 0 deletions test/specs/new/space_after_table.md
View file
Open in desktop
@@ -0,0 +1,8 @@
---
gfm: true
---
| a | b |
|---|---|
| 1 | 2 |

there should be a single space in the line above