Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix every third list item broken #2318

Merged
merged 2 commits into from Dec 9, 2021

Conversation

@calculuschild
Copy link
Contributor

@calculuschild calculuschild commented Dec 9, 2021

Marked version:

4.0.6

Description

Fixes #2314

#2302 mistakenly used list.loose as a flag to end list items early if they start with two blank lines. Technically that is a different scenario from being "loose", so legitimate loose lists were also hitting that flag and prematurely ending the list after the second item. This PR just adds a separate flag endEarly to handle that case.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@calculuschild calculuschild requested review from styfle and UziTech Dec 9, 2021
@vercel
Copy link

@vercel vercel bot commented Dec 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/DHNZFHw9M4ntqboD5p5STLypQVHA
Preview: https://markedjs-git-fork-calculuschild-fixthirdsublistbroken-markedjs.vercel.app

UziTech
UziTech approved these changes Dec 9, 2021
styfle
styfle approved these changes Dec 9, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@styfle styfle merged commit 346b162 into markedjs:master Dec 9, 2021
10 checks passed
github-actions bot pushed a commit that referenced this issue Dec 9, 2021
## [4.0.7](v4.0.6...v4.0.7) (2021-12-09)

### Bug Fixes

* Fix every third list item broken ([#2318](#2318)) ([346b162](346b162)), closes [#2314](#2314)
@github-actions
Copy link

@github-actions github-actions bot commented Dec 10, 2021

🎉 This PR is included in version 4.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants