Configuration: allow "getReporter" method to require node modules

Fixes jscs-dev#1030
markelog · May 29, 2015 · e76c2f0 · e76c2f0
1 parent 3850b15
commit e76c2f0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 14 deletions.
diff --git a/lib/cli-config.js b/lib/cli-config.js
@@ -165,6 +165,15 @@ exports.getReporter = function(reporter, colors) {
         writer = null;
     }
 
+    if (!writer) {
+        try {
+            writer = require(reporter);
+            writerPath = reporter;
+        } catch (e) {
+            writer = null;
+        }
+    }
+
     return {
         path: writerPath,
         writer: writer

diff --git a/test/specs/cli-config.js b/test/specs/cli-config.js
@@ -162,20 +162,6 @@ describe('modules/cli-config', function() {
             assert.equal(reporter.path, path.resolve('./lib/reporters/junit'));
         });
 
-        it('should get junit reporter with part of the path', function() {
-            var reporter = configFile.getReporter('./junit.js');
-
-            assert.equal(typeof reporter.writer, 'function');
-            assert.equal(reporter.path, path.resolve('./lib/reporters/junit.js'));
-        });
-
-        it('should get junit reporter with part of the path without extension', function() {
-            var reporter = configFile.getReporter('./junit');
-
-            assert.equal(typeof reporter.writer, 'function');
-            assert.equal(reporter.path, path.resolve('./lib/reporters/junit'));
-        });
-
         it('should get reporter with partial path', function() {
             var reporter = configFile.getReporter('./test/data/reporter/test-reporter.js');
 
@@ -202,5 +188,19 @@ describe('modules/cli-config', function() {
 
             configFile.__set__('supportsColor', old);
         });
+
+        it('should fake reporter from node', function() {
+            var reporter = configFile.getReporter('path');
+
+            assert.equal(typeof reporter.writer, 'object');
+            assert.equal(reporter.path, 'path');
+        });
+
+        it('should fake reporter from node_modules', function() {
+            var reporter = configFile.getReporter('sinon');
+
+            assert.equal(typeof reporter.writer, 'object');
+            assert.equal(reporter.path, 'sinon');
+        });
     });
 });