Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: v1.0.4 has shared state issue. #6

Closed
MarketingPip opened this issue May 6, 2023 · 1 comment
Closed

[Bug Report]: v1.0.4 has shared state issue. #6

MarketingPip opened this issue May 6, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@MarketingPip
Copy link
Member

This current version has a shared state issue - which went un-noticed to my own self error in not properly testing the library before publishing it.

In the case's where more than <code-runnner> is included the dom. The value from the last included web component is being used to be sent to the API.

This is due to not properly grabbing the values of the Ace Editor API - as far as I do believe.

Steps to reproduce the behavior:

  1. Go to demo page.
  2. Add console.log('test') into "Undefined Code".
  3. Press run on both displayed components.

Previous versions of this web component do NOT have this issue.

@MarketingPip MarketingPip added the bug Something isn't working label May 6, 2023
@MarketingPip
Copy link
Member Author

This issue has been now been solved in version: 1.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant