better SHA algorithm

markevans · Aug 22, 2014 · 00bb029 · 00bb029 · mkhatib · Feb 15, 2015
1 parent 418f793
commit 00bb029
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/dragonfly/job.rb b/lib/dragonfly/job.rb
@@ -155,7 +155,7 @@ def sha
         raise CannotGenerateSha, "A secret is required to sign and verify Dragonfly job requests. "\
                                  "Use `secret '...'` or disable `protect_from_dos_attacks` in your config."
       end
-      Digest::SHA1.hexdigest("#{to_unique_s}#{app.secret}")[0...8]
+      OpenSSL::HMAC.hexdigest('SHA256', app.secret, to_unique_s)[0,16]
     end
 
     def validate_sha!(sha)

diff --git a/spec/dragonfly/job_spec.rb b/spec/dragonfly/job_spec.rb
@@ -405,7 +405,7 @@
     end
 
     it "should be of the correct format" do
-      @job.sha.should =~ /^\w{8}$/
+      @job.sha.should =~ /^\w{16}$/
     end
 
     it "should be the same for the same job steps" do