Merge pull request #488 from tomasc/master

replace Open3.popen3 with Open3.capture3
markevans · Sep 18, 2018 · 7ed572b · 7ed572b
2 parents 3ad0c6d + d597903
commit 7ed572b
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/dragonfly/shell.rb b/lib/dragonfly/shell.rb
@@ -43,12 +43,9 @@ def run_command(command)
     else
 
       def run_command(command)
-        Open3.popen3 command do |stdin, stdout, stderr, wait_thread|
-          stdin.close_write # make sure it doesn't hang
-          status = wait_thread.value
-          raise CommandFailed, "Command failed (#{command}) with exit status #{status.exitstatus} and stderr #{stderr.read}" unless status.success?
-          stdout.read
-        end
+        stdout_str, stderr_str, status = Open3.capture3(command)
+        raise CommandFailed, "Command failed (#{command}) with exit status #{status.exitstatus} and stderr #{stderr_str}" unless status.success?
+        stdout_str
       end
 
     end