Bug fix: TypeError: DataFrame.sort() got an unexpected keyword argument 'reverse' #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was test driving tidypolars today (looks great!), but I had some trouble using
arrange
.I checked polars docs, which state that sort accepts:
For this reason, I renamed the argument from
reverse
todescending
, and it seems to work. I haven't run any tests.I hope this helps, and sorry for a drive-by commit/PR.
— Maciej
Update: env info yml file attached as environment_yml.txt