filerec_count_shared(): fix sharing accounting #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change `filerec_count_shared()` incorrectly accounted for
extent end compared to file end:
$ ls -lh /nix/var/nix/db/db.sqlite
-rw-r--r-- 1 root root 1.4G Nov 9 22:21 /nix/var/nix/db/db.sqlite
Before the change due to incorrect tail handling sharing reported size
larger than the file itself:
$ ./show-shared-extents /nix/var/nix/db/db.sqlite
/nix/var/nix/db/db.sqlite: 27065321263104 shared bytes
After the change sharing reports a reasonable value:
$ ./show-shared-extents /nix/var/nix/db/db.sqlite
/nix/var/nix/db/db.sqlite: 1169276928 shared bytes
Note: before the change sharing reported a few orders of magnitude
savings larger than initial file size. After the change the value is
more reasonable.
|
Thank you for improving this report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change
filerec_count_shared()incorrectly accounted for extent end compared to file end:Before the change due to incorrect tail handling sharing reported size larger than the file itself:
After the change sharing reports a reasonable value:
Note: before the change sharing reported a few orders of magnitude savings larger than initial file size. After the change the value is more reasonable.