Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gradel structure - reuse tar file #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markflyhigh
Copy link
Owner

@markflyhigh markflyhigh commented Mar 29, 2019

This experimental is based on a assumption that py2 and py3 sdist works the same and the tar file can be used inter-changeable.

  • only build sdist once (so put task in sdks/python/build.gradle). This task should execute first before parallel execution of many test tasks. The generated tar file can be used in all downstream tasks (e.g. tox tests and IT tests).
  • move copy sources out of sdist and only tox tasks depend on it
  • re-organized and refactor tasks, params in BeamModulePlugin to make code cleaner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@markflyhigh markflyhigh changed the title New Gradel structure - move copy to tox tasks only New Gradel structure - reuse tar file Jul 2, 2019
@markflyhigh
Copy link
Owner Author

test test

markflyhigh added a commit that referenced this pull request Aug 31, 2019
hub api repos//issues/6/comments -f "body=test test"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant