Skip to content

Commit

Permalink
Added gensim dep to gensim trainer
Browse files Browse the repository at this point in the history
No difference in practice, since it's enforced by the output datatype,
but good to have it there for clarity
  • Loading branch information
markgw committed Aug 3, 2020
1 parent 83fb734 commit 1cc2563
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/python/pimlico/modules/gensim/lda/execute.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import logging
from logging import getLogger

from gensim.models import LdaModel, TfidfModel

from pimlico.core.modules.base import BaseModuleExecutor
Expand Down
4 changes: 4 additions & 0 deletions src/python/pimlico/modules/gensim/lda/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
Add test pipeline and test
"""
from pimlico.core.dependencies.python import gensim_dependency
from pimlico.core.modules.base import BaseModuleInfo
from pimlico.core.modules.options import str_to_bool, comma_separated_strings, opt_type_help
from pimlico.datatypes import GensimLdaModel, GroupedCorpus, Dictionary
Expand Down Expand Up @@ -132,3 +133,6 @@ class ModuleInfo(BaseModuleInfo):
"default": 0.01,
},
}

def get_software_dependencies(self):
return super(ModuleInfo, self).get_software_dependencies() + [gensim_dependency]

0 comments on commit 1cc2563

Please sign in to comment.