Fixed bug in GloVe trainer

Problem with file handles to subprocesses
markgw · Oct 30, 2020 · ba0f86a · ba0f86a
1 parent 0814c84
commit ba0f86a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/python/pimlico/modules/embeddings/glove/execute.py b/src/python/pimlico/modules/embeddings/glove/execute.py
@@ -126,8 +126,7 @@ def execute(self):
                 glove_cmd.extend(["-seed", str(opts["seed"])])
             self.log.info("  Command: {}".format(" ".join(glove_cmd)))
             try:
-                with io.open(cooccur_file, "rb") as input_f, io.open(cooccur_shuf_file, "wb") as output_f:
-                    subprocess.check_call(glove_cmd, stdin=input_f, stdout=output_f)
+                subprocess.check_call(glove_cmd)
             except subprocess.CalledProcessError as e:
                 raise_from(ModuleExecutionError("call to GloVe's glove command failed: {}".format(e)), e)
             glove_output.file_written("vectors.txt")