Skip to content

Commit

Permalink
SPARK-1478.2 Fix incorrect NioServerSocketChannelFactory constructor …
Browse files Browse the repository at this point in the history
…call

The line break inadvertently means this was interpreted as a call to the no-arg constructor. This doesn't exist in older Netty even. (Also fixed a val name typo.)

Author: Sean Owen <srowen@gmail.com>

Closes apache#1466 from srowen/SPARK-1478.2 and squashes the following commits:

59c3501 [Sean Owen] Line break caused Scala to interpret NioServerSocketChannelFactory constructor as the no-arg version, which is not even present in some versions of Netty
  • Loading branch information
srowen authored and tdas committed Jul 17, 2014
1 parent d988d34 commit 1fcd5dc
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,15 @@ class FlumeReceiver(

private def initServer() = {
if (enableDecompression) {
val channelFactory = new NioServerSocketChannelFactory
(Executors.newCachedThreadPool(), Executors.newCachedThreadPool());
val channelPipelieFactory = new CompressionChannelPipelineFactory()
val channelFactory = new NioServerSocketChannelFactory(Executors.newCachedThreadPool(),
Executors.newCachedThreadPool())
val channelPipelineFactory = new CompressionChannelPipelineFactory()

new NettyServer(
responder,
new InetSocketAddress(host, port),
channelFactory,
channelPipelieFactory,
channelFactory,
channelPipelineFactory,
null)
} else {
new NettyServer(responder, new InetSocketAddress(host, port))
Expand Down

0 comments on commit 1fcd5dc

Please sign in to comment.