Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linebreakpoints get lost when applying the formatting #24

Closed
markiewb opened this issue Sep 26, 2013 · 10 comments
Closed

Linebreakpoints get lost when applying the formatting #24

markiewb opened this issue Sep 26, 2013 · 10 comments
Labels
bug
Milestone
1.13.0

Comments

@markiewb
Copy link
Collaborator

No description provided.

@marccollin
Copy link

any breakpoint who exist are removed after using this plugin.

@markiewb
Copy link
Collaborator Author

Yes that is a known issue. The text in the editor is replaced and the breakpoints are lost.

@vra5107
Copy link

vra5107 commented Dec 16, 2013

I was just thinking about this the other day, IMO removing the break points is the best way to handle this. If the code is reorganized, wouldn't it be hard to guess where the break points are ?

@markiewb
Copy link
Collaborator Author

I had no time to have a detailed look at the available debugger API yet. If
you like you could try it yourself and provide a pull request...

Best regards, markiewb
Am 16.12.2013 23:10 schrieb "Venkat Akkineni" notifications@github.com:

I was just thinking about this the other day, IMO removing the break
points is the best way to handle this. If the code is reorganized, wouldn't
it be hard to guess where the break points are ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-30706259
.

@vra5107
Copy link

vra5107 commented Dec 16, 2013

My hands are currently quite full too :) , but I will most definitely take a look at it if I get a chance. Thanks a million for this plugin however, IMO this is your most important Netbeans plugin. I created the original bugzilla request for eclipse code formatter support a few years ago but never got started with the plugin mainly because it is daunting work from my stand-point.

@markiewb
Copy link
Collaborator Author

Related to https://netbeans.org/bugzilla/show_bug.cgi?id=226437

@derylspielman
Copy link

If we could fix this it would be amazing. It is preventing us from using your plugin for our developers. Is there any chance it will ever get fixed?

@markiewb
Copy link
Collaborator Author

markiewb commented Aug 6, 2014

@derylspielman : Thank you for your interest. I have an idea to fix this, but this is tedious and I have no time.

@markiewb
Copy link
Collaborator Author

markiewb commented Oct 3, 2014

In the next version at least the class/method/field breakpoints will be preserved. See state of #47
Line breakpoint will still be lost.

@markiewb markiewb changed the title Breakpoints get lost when applying the formatting Linebreakpoints get lost when applying the formatting Jan 29, 2016
@markiewb markiewb mentioned this issue Feb 13, 2016
Closed
@markiewb
Copy link
Collaborator Author

http://bits.netbeans.org/dev/javadoc/org-openide-text/org/openide/text/Line.Set.html#getOriginalLineNumber-org.openide.text.Line-

funfried pushed a commit that referenced this issue Jan 21, 2020
Integrated the formatter deeper into NetBeans, that means the formatt…
a3aff30 
…er is now triggered by the NetBeans actions itself, therefore every reformat trigger uses now the configured formatter, e.g. also after a code template was inserted. That means also that there is no more format on save option, this can be achieved now by NetBeans' On-Save action.

So with this commit, these issues are fixed or at least improved:
#24 Preserve linebreakpoints has improved (still not as perfect as with the internal NetBeans formatter but pretty close)
#92 The configured formatter takes now care when a code template is inserted, so if it tells to not format a specific part this part is ignored from formatting
#17 Hanlding of guarded blocks has improved by design
@funfried funfried added this to the 1.13.0 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
5 participants
@vra5107 @derylspielman @markiewb @marccollin @funfried