Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates and bump minimum supported versions #245

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 10, 2021

Composer lists PHP 5.5 as the minimum supported version, yet this isn't actually tested. So, I've bumped the PHP minimum up to 7.1.3 which matches Symfony 4 and the lowest tested PHP version. This also helps unblock bringing in new code to address Symfony 5.3 deprecations.

I've also tightened the supported Symfony version list up so now only the 3.4 and 4.4 LTS' are supported, as well as only ^5.2 (this effectively drops 4.0-3 and 5.0-1).

The dependency list is updated to list out all of the actual dependencies instead of relying on transient dependencies to bring them in.

For CI, the matrix is updated to test PHP 7.4 and 8.0 (previously untested), to use Flex for restricting the Symfony version range (which avoids needing to install the symfony/symfony monorepo, which hid the broken dependency list), and makes sure all supported Symfony versions are tested. There is also now a --prefer-lowest build in the queue to ensure the minimum dependencies are valid.

(On a side note, migrating to GitHub Actions would be a good idea here too)

"lexik/jwt-authentication-bundle": "^1.1|^2.0",
"symfony/config": "^3.4|^4.4|^5.2",
"symfony/console": "^3.4|^4.4|^5.2",
"symfony/dependency-injection": "^3.4.27|^4.4|^5.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec\Gesdinet\JWTRefreshTokenBundle\DependencyInjection\GesdinetJWTRefreshTokenExtensionSpec class makes use of the internal ContainerBuilder::removeBindings(), which was renamed at 3.4.27 from whatever it was previously, hence the minimum here being set on a later patch release.

@markitosgv markitosgv merged commit fe9c459 into markitosgv:master Jun 28, 2021
@mbabker mbabker deleted the env-updates branch June 28, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants