-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting refresh token in cookie #274
Conversation
4bd7b9b
to
638e6cc
Compare
This commit is the result of cherry-picking the following commits on top of the current master branch, resolving conflicts, making some minor changes and rebasing the lot into a single commit: markitosgv@c6f67b0 markitosgv@f9fbdf5 markitosgv@3267470 Resolved conflicts in: DependencyInjection/Configuration.php DependencyInjection/GesdinetJWTRefreshTokenExtension.php EventListener/AttachRefreshTokenOnSuccessListener.php README.md Request/RequestRefreshToken.php Resources/config/services.php spec/EventListener/AttachRefreshTokenOnSuccessListenerSpec.php spec/Request/RequestRefreshTokenSpec.php
Fixes: ``` Error: Undefined class constant 'SAMESITE_NONE' ```
Thanks for reviewing @mbabker, I believe I've fixed the things you mentioned. |
Hey @markitosgv have you had a chance to look at this? Let me know if you would like to see some changes or if you have any other reservations |
Any news when this will be merged? |
@markitosgv |
checked and merged ;-) |
This commit is the result of cherry-picking the following commits on top
of the current master branch, resolving conflicts, making some minor
changes and rebasing the lot into a single commit:
c6f67b0
f9fbdf5
3267470
Resolved conflicts in:
DependencyInjection/Configuration.php
DependencyInjection/GesdinetJWTRefreshTokenExtension.php
EventListener/AttachRefreshTokenOnSuccessListener.php
README.md
Request/RequestRefreshToken.php
Resources/config/services.php
spec/EventListener/AttachRefreshTokenOnSuccessListenerSpec.php
spec/Request/RequestRefreshTokenSpec.php