Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting refresh token in cookie #274

Merged
merged 6 commits into from
Nov 4, 2021

Conversation

Jayfrown
Copy link
Contributor

This commit is the result of cherry-picking the following commits on top
of the current master branch, resolving conflicts, making some minor
changes and rebasing the lot into a single commit:

c6f67b0
f9fbdf5
3267470

Resolved conflicts in:
DependencyInjection/Configuration.php
DependencyInjection/GesdinetJWTRefreshTokenExtension.php
EventListener/AttachRefreshTokenOnSuccessListener.php
README.md
Request/RequestRefreshToken.php
Resources/config/services.php
spec/EventListener/AttachRefreshTokenOnSuccessListenerSpec.php
spec/Request/RequestRefreshTokenSpec.php

This commit is the result of cherry-picking the following commits on top
of the current master branch, resolving conflicts, making some minor
changes and rebasing the lot into a single commit:

markitosgv@c6f67b0
markitosgv@f9fbdf5
markitosgv@3267470

Resolved conflicts in:
	DependencyInjection/Configuration.php
	DependencyInjection/GesdinetJWTRefreshTokenExtension.php
	EventListener/AttachRefreshTokenOnSuccessListener.php
	README.md
	Request/RequestRefreshToken.php
	Resources/config/services.php
	spec/EventListener/AttachRefreshTokenOnSuccessListenerSpec.php
	spec/Request/RequestRefreshTokenSpec.php
Fixes:

```
Error: Undefined class constant 'SAMESITE_NONE'
```
@Jayfrown
Copy link
Contributor Author

Thanks for reviewing @mbabker, I believe I've fixed the things you mentioned.

@Jayfrown
Copy link
Contributor Author

Jayfrown commented Sep 4, 2021

Hey @markitosgv have you had a chance to look at this? Let me know if you would like to see some changes or if you have any other reservations

@CIT-SW
Copy link

CIT-SW commented Oct 4, 2021

Any news when this will be merged?

@CIT-SW
Copy link

CIT-SW commented Nov 3, 2021

@markitosgv
Hey there! We completely understand when an open source project can't get the amount of attention from the author that would be needed and we really appreciate you're work. Nevertheless it's a bit hard to figure out if we could actually use your package or not in our project as long as we can't tell if and when refresh token via cookie will be available (and if the package is going to be further maintained at a minimum level).
Hence, would you be so kind as to let us know if and when this PR can be merged? Of course, "no" is a valid answer as well, it would even be better to know that you are not going to merge this PR / maintain the package than not knowing anything about it. ;-)
Looking forward to your reply!

@markitosgv markitosgv merged commit ef32366 into markitosgv:master Nov 4, 2021
@markitosgv
Copy link
Owner

checked and merged ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants