Fixed default (placeHolder) selection after using a tag having either openBlockWith or closeBlockWith property #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openBlockWith or closeBlockWith property.
jaysalvat
added a commit
that referenced
this pull request
Jan 29, 2013
Fixed default (placeHolder) selection after using a tag having either openBlockWith or closeBlockWith property
|
Thanks for your contribution and sorry for the late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for this great library!
I believe there is an issue with tags using either "openBlockWith" or "closeBlockWith". If you don't select any text and apply such tag, carret is supposed to select placeholder text (or just move inside the openWith and closeWith tags if there is no placeholder), but indices are wrong when openBlockWith or closeBlockWith are used. This pull request should fix the issue.
Regards,
Remi