Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save media as/now won't download gif #42

Closed
grssam opened this issue Aug 29, 2017 · 8 comments
Closed

Save media as/now won't download gif #42

grssam opened this issue Aug 29, 2017 · 8 comments

Comments

@grssam
Copy link

grssam commented Aug 29, 2017

If I run the gesture on a gif image, the download get initiated but always fails. Even retrying manually from download panel fails.

Example page : http://clamiral.tumblr.com/post/155735734176

@marklieberman
Copy link
Owner

It's working fine for me. It might be on your end. Right click on the failed download and select "Copy Download Link" and paste it here please.

@grssam
Copy link
Author

grssam commented Aug 29, 2017

right click -> copy image location - http://68.media.tumblr.com/82f7bbc1d06fcdbf1fd60cc2e8ced61a/tumblr_ojn0icZO9U1tai552o1_400.gif

failed download -> right click -> Copy download link - http://68.media.tumblr.com/82f7bbc1d06fcdbf1fd60cc2e8ced61a/tumblr_ojn0icZO9U1tai552o1_400.gif

PS : I am able to download using the normal right click -> save image as...

@marklieberman
Copy link
Owner

I've tried it using release, developer, and nightly editions. It downloads fine using Save Media Now and Save Media As commands. The URL on the download is the correct one, so it means Foxy Gestures is calling the download API with the correct image source. Any issue with the download is unlikely to be from Foxy Gestures. Can you reproduce this on any other page or website?

@grssam
Copy link
Author

grssam commented Aug 29, 2017

Looks like a tumblr only thing. I can download just fine from https://giphy.com/gifs/studiosoriginals-samantha-maurer-d3JIvDICfCu8jgaI or some other site.. weird.

I see the following exceptions in Browser Console:

Unchecked lastError value: Error: Frame not found, or missing host permission  ExtensionCommon.jsm:407
Error: WebExtension context not found! ExtensionParent.jsm:821:13
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIChannel.contentType]  DownloadCore.jsm:1982

@grssam
Copy link
Author

grssam commented Aug 29, 2017

(similar exceptions do not come on any other non-tumblr site.)

@marklieberman
Copy link
Owner

I'm not seeing that error in my browsers when I have the GIF from tumblr.

That error is calling out [nsIChannel.contentType]. I guess it doesn't like the value it is seeing? Do you have any other addons that intercept web requests? There a good chance you've encountered a bug with Firefox as well, since that error is coming from inside Firefox code.

@grssam
Copy link
Author

grssam commented Aug 29, 2017

I barely have any web extension based addons. But I can debug this using Browser Debugger later tomorrow.

@marklieberman
Copy link
Owner

@grssam I'm going to close this issue. I will re-open if you discover any pertinent information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants