Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed link to go to job description #46

Merged
merged 2 commits into from Aug 12, 2019
Merged

fixed link to go to job description #46

merged 2 commits into from Aug 12, 2019

Conversation

MCHadley
Copy link
Collaborator

Job description link was going to main page, fixed to send to skylight jobs page

marklocklear
marklocklear requested changes Aug 12, 2019
View reviewed changes
Copy link
Owner

@marklocklear marklocklear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's use "link" rather than "clicklink" in array you are adding to jobs_array. So up in line 408, lets change that variable name from clickLink to "link". Resubmit and I will test and merge. Thanks!

@MCHadley
Copy link
Collaborator Author

Changed!

marklocklear
marklocklear approved these changes Aug 12, 2019
View reviewed changes
Copy link
Owner

@marklocklear marklocklear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marklocklear marklocklear merged commit aed9b13 into master Aug 12, 2019
@marklocklear marklocklear deleted the skylightJobs branch December 11, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklocklear marklocklear marklocklear approved these changes

Assignees

@marklocklear marklocklear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MCHadley @marklocklear