Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Configurable CPF config file #762

Closed
kosed opened this issue Apr 24, 2017 · 6 comments
Closed

Configurable CPF config file #762

kosed opened this issue Apr 24, 2017 · 6 comments

Comments

@kosed
Copy link

kosed commented Apr 24, 2017

Parametirized pipeline-config file

We are using for a project with multiple environments. We therefore have multiple $env.properties file.
We are using CPF and we also need to have different pipeline-config files but the "pipeline-config.xml" is hard coded and this is not possible.

We have made the change in server_config.rb (monkey patching as you described was also an option) by using a property variable instead of the hard coded filename.

Roxy version : 1.7.5

@dmcassel
Copy link
Collaborator

@kosed can you submit your changes in a PR against the dev branch? Instructions in CONTRIBUTING.md

@grtjn
Copy link
Contributor

grtjn commented Jun 1, 2017

@kosed I think there is no need for changes. pipeline-config.xml can contain references to properties, and those will be replace. You can use something like ${my-prop-name}, provided you have a my-prop-name=value in build-properties or in your {env}.properties.

Please confirm if that works for you by closing this ticket.

@grtjn grtjn self-assigned this Jun 1, 2017
@kosed
Copy link
Author

kosed commented Jun 6, 2017

Hello,

@dmcassel, our change is a basic one liner but I haven't been able to read the contributing info page so far.

@grtjn, Using properties is a very interesting solution for this case.
Still I think there might be a possible limitation is you actually need different pipelines/domains on different $env. May be a de/activation flag will help here. Not sure if this already exist.
What do you think ?

@grtjn
Copy link
Contributor

grtjn commented Jun 6, 2017

Ah, parametrized in thát way. No, there are no options yet to enable/disable pipelines or domains with properties. Making the filename of the pipeline-config configurable makes sense. And that is probably indeed pretty much a oneliner.. :)

@grtjn grtjn modified the milestones: May 2017, July 2017 Jun 6, 2017
RobertSzkutak added a commit that referenced this issue Jun 11, 2017
Fixed #762: Made pipeline-config.xml configurable
@grtjn
Copy link
Contributor

grtjn commented Jun 12, 2017

Wasn't a oneliner after all, but not very difficult either..

Fixed in DEV..

@grtjn grtjn closed this as completed Jun 12, 2017
@kosed
Copy link
Author

kosed commented Jun 12, 2017

Thanx @grtjn :-)

@grtjn grtjn changed the title CPF deploy config file Configurable CPF config file Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants