This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fixed #377: Added support for deploy rest of .sjs, and some cleanup #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and some cleanup
| # TODO: I'm assuming there's a way to consolidate the following if/elsif but I'm a Ruby newbie and I'm being conservative | ||
| if (file_type == 'xquery') | ||
|
|
||
| if (is_sjs) |
There was a problem hiding this comment.
This might need a second look. Didn't have a .sjs transform at hand, not sure it works properly..
There was a problem hiding this comment.
It's working. Just tested it.
paxtonhare
added a commit
that referenced
this pull request
Mar 10, 2015
Fixed #377: Added support for deploy rest of .sjs, and some cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special thanks to @steliann for providing working code. Only rearranged a bit, and did some cleanup..