This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fixed #359: added separate mlcp user/pass properties #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -989,9 +989,11 @@ def mlcp | |||
| end | |||
| end | |||
|
|
|||
| @ml_username = @properties['ml.mlcp-user'] | |||
| @ml_password = @properties['ml.mlcp-password'] | |||
There was a problem hiding this comment.
Just as an extra precaution, perhaps these should be:
@ml_username = @properties['ml.mlcp-user'] || @properties['ml.user']
@ml_password = @properties['ml.mlcp-password'] || @ml_password
Not everyone knows about or uses the ./ml upgrade feature and thus might not get those properties added to default.properties.
|
Done! |
paxtonhare
added a commit
that referenced
this pull request
Apr 30, 2015
Fixed #359: added separate mlcp user/pass properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging @ml_user and @ml_pass to make full use of password_prompt..