Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Fixed #497: fixed reading task-host #527

Merged
merged 2 commits into from
Mar 10, 2016

Conversation

grtjn
Copy link
Contributor

@grtjn grtjn commented Sep 22, 2015

Self-test against ML8 runs clean. #497/#500

@grtjn grtjn added this to the 1.7.3 milestone Sep 22, 2015
@dmcassel
Copy link
Collaborator

@ml.server may be "localhost", which is good enough to direct traffic to MarkLogic, but xdmp:host("localhost") will fail.

XDMP-NOSUCHHOST: xdmp:host("localhost") -- No such host localhost

@grtjn
Copy link
Contributor Author

grtjn commented Sep 22, 2015

Hmm, good one. We need something smarter, just not sure what. I'd rather not default to bootstrap-host or first host in group, to keep the option to have a schedule on all hosts..

@dmcassel
Copy link
Collaborator

Localhost is a special case. I think if we'd be safe guessing that "localhost" => xdmp:host().

@grtjn
Copy link
Contributor Author

grtjn commented Sep 22, 2015

Yeah, but the assumption is actually all wrong. @ml.server doesn't contain a host-name at all, but something that happens to resolve to the MarkLogic host ip against the DNS or the local hosts file..

@dmcassel
Copy link
Collaborator

Agreed. Sometimes those will match, sometimes not.

@peetkes
Copy link
Contributor

peetkes commented Jan 27, 2016

Works fine by me, except for the placeholder in the sample config. You should be able to pick any of the hosts in the group in a convenient way @ml.group-hosts[n]

@grtjn
Copy link
Contributor Author

grtjn commented Jan 27, 2016

I think I'll split this PR. Peet's suggestion could be useful, but needs more thought..

@dmcassel
Copy link
Collaborator

@grtjn should we close this PR for now?

@grtjn
Copy link
Contributor Author

grtjn commented Jan 28, 2016

Not needed. I'll just take out the configs, and continue discussion about it in #500..

@grtjn grtjn changed the title Fixed #497/#500: fixed reading task-host, changed its default Fixed #497: fixed reading task-host Jan 29, 2016
@dmcassel
Copy link
Collaborator

dmcassel commented Mar 4, 2016

@grtjn what's the state of this PR? Still valid?

@grtjn
Copy link
Contributor Author

grtjn commented Mar 4, 2016

Yes, should be ready to merge. I took out the tricky part with host names (#500)..

dmcassel added a commit that referenced this pull request Mar 10, 2016
@dmcassel dmcassel merged commit 7155e2b into marklogic-community:dev Mar 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants