This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fix #703 #761
Merged
Fix #703 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcassel
reviewed
Apr 20, 2017
| restart_basic | ||
| else | ||
| # defaults to verified restart | ||
| old_timestamp = go(%Q{http://#{@properties["ml.server"]}:8001/admin/v1/timestamp}, "get").body |
There was a problem hiding this comment.
didn't know this endpoint existed. nice!
dmcassel
suggested changes
Apr 20, 2017
deploy/lib/server_config.rb
Outdated
| restart_basic | ||
| retry_count = 0 | ||
| retry_max = 5 | ||
| retry_interval= 10 |
There was a problem hiding this comment.
I think at least one of these should be property-driven -- desired values may differ depending on the environment. Please add a property to default.properties and make use of it here.
|
Implemented review points. Kindly review again. Thank you.
|
dmcassel
approved these changes
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703
Note:
We can still skip verification by passing --verify=false