-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advanced search page #372
Comments
@dmcassel @dsokolsky where do you think this should go in the UI? |
I'd toss that question to Steve Gehring |
OK, here is how I think we should structure this page for now:
Is this enough to get you going with it Mike? |
I think so. I have something more or less working and I'll check it in after a little more testing. We can iterate on feedback. |
This seemed like a good time to use a topic branch, but let me know if you'd rather just have this in the docapp branch. |
I think it is OK on this topic branch for now. I just tried it out and I am seeing this: /do-search?advanced=1 SEARCH-INVALARGS: (err:FOER0000) Invalid arguments: output must be 'search:query' or 'cts:query' |
Odd, it doesn't do that on my 8.0-1.1 install. Maybe a change in the search API? Should be easy enough to work around, though. |
You mentioned replacing the Main Site link. I'm with you that the advanced search link would be good there, but we should have a link somewhere to the company site -- preferably more prominent than the current one. |
Danny, were you trying this on pubs or pubs-new? I suspect you're on pubs and ML7. Mike's search:parse call is using "cts:annotated-query", which smells like this incompatibility to me: |
@dmcassel , as far as the link to the main site, I think that should get incorporated into the new header design (if that every happens). |
Kim is correct, I am running MarkLogic 7. I get farther now, but now I am seeing this error with this request: /do-search?api=false&v=&advanced=1&q=&q_none=&q_cat=&q_title=javascript SEARCH-INVALARGS: (err:FOER0000) Invalid arguments: output must be 'search:query' or 'cts:query' |
I suspect you'll be running ML8 for docs by the time we work out the full UI for this. But meanwhile it's good sample code for anyone looking at how to handle incompatibilities. |
Well, production is still running 7.0.... |
We need to migrate the environments to Red Hat 6, that is why it is not there yet. |
This time I tested with ML7 and ML8. This is actually a new branch with the same name, but different history. I deleted the old one so I could rebase from the latest docapp. Sorry if that's confusing: not usual practice, but it's a topic branch. Anyway you may want to delete the old copy and get the new one:
|
OK, I got it to work. Here are a few things:
|
One quick way to get back to normal search is to use the old search box in the upper right corner. The nice thing about this preliminary UI is that it doesn't require javascript. But I agree that there should be better UI. I tend to think it should either act like a sub-panel with a show-hide widget, or a pseudo-window with its own open-close widget. Thoughts? In the long run I'd like to see a fairly capable query builder, something like this. But it's going to take a while to get there. |
I was thinking that we could always include it, but hide it via css when you click a link (Advanced). So I think it should be a sub-panel with a show-hide widget. The lack of javascript thing does not seem like such a big deal, seeing as how javascript is pretty necessary for the app anyway... |
@dsokolsky This may be functional enough as far as the data model and JavaScript are concerned: see what you think. If you want to tweak any of the CSS or container XML that's all in |
Anything new deserves a new bug. |
Add an advanced search page that provides basic functionality for each of the defined search constraints.
The text was updated successfully, but these errors were encountered: