Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-valued equality expressions in Optic builder #1248

Closed
ehennum opened this issue Aug 20, 2020 · 1 comment
Closed

multi-valued equality expressions in Optic builder #1248

ehennum opened this issue Aug 20, 2020 · 1 comment

Comments

@ehennum
Copy link
Contributor

ehennum commented Aug 20, 2020

Currently, the Optic builder supports exactly two values in an equality expression.

Equality of a set of values can be expressed with AND relations over equality pairs, but such syntax is verbose and requires knowing the number of values in advance (or generating the entire expression).

Per internal task 47546, the Optic builder should support two or more values in an equality expression.

While generating the new interface, also fix the internal bug 54922 on the link for the param() JavaDoc.

@ehennum ehennum added this to the 5.next milestone Aug 20, 2020
@ehennum ehennum self-assigned this Aug 20, 2020
@ehennum ehennum assigned georgeajit and unassigned ehennum Aug 20, 2020
@ehennum ehennum added test and removed fix labels Aug 20, 2020
@ehennum
Copy link
Contributor Author

ehennum commented Aug 20, 2020

Assigning for awareness in case of regression. The unit tests should provide sufficient coverage of the increased cardinality on the arguments to the eq() operator.

@georgeajit georgeajit added ship and removed test labels Oct 5, 2020
@ehennum ehennum closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants