Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logback dependency #424

Closed
sammefford opened this issue Jul 8, 2016 · 1 comment
Closed

Remove logback dependency #424

sammefford opened this issue Jul 8, 2016 · 1 comment

Comments

@sammefford
Copy link
Contributor

We wisely use slf4j so our customers can choose their preferred logging framework (log4j, commons logging, java.util.logging, or logback). But we mistakenly include logback-classic in our pom.xml dependencies, thus forcing our clients to use logback-classic. This is incorrect usage of slf4j according to this page: http://www.slf4j.org/manual.html

We should remove logback-classic from our pom.xml. While at it, we should see if we can remove commons-logging.

@sammefford sammefford added this to the java-client-api-4.0-ea3 milestone Jul 8, 2016
@sammefford sammefford self-assigned this Jul 8, 2016
sammefford added a commit that referenced this issue Jul 23, 2016
@sammefford sammefford added test and removed fix labels Jul 23, 2016
@sammefford sammefford assigned georgeajit and unassigned sammefford Jul 23, 2016
@georgeajit georgeajit added ship and removed test labels Aug 3, 2016
@georgeajit
Copy link
Contributor

Verified the POM file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants