Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 9 #862

Closed
jmakeig opened this issue Dec 1, 2017 · 11 comments
Closed

Support Java 9 #862

jmakeig opened this issue Dec 1, 2017 · 11 comments

Comments

@jmakeig
Copy link
Contributor

jmakeig commented Dec 1, 2017

No description provided.

@jmakeig jmakeig self-assigned this Dec 1, 2017
@jmakeig
Copy link
Contributor Author

jmakeig commented Dec 1, 2017

Came up in #858

@ehennum
Copy link
Contributor

ehennum commented Oct 15, 2018

The issue seems to be testing with Java 9 (and, presumably, Java 10 now) and fixing any bugs that show up.

Adding features to exploit the new capabilities of Java 9 and 10 would be in individual RFEs separate from this test item.

@ehennum ehennum added test and removed new labels Oct 15, 2018
@georgeajit georgeajit added verify and removed test labels Nov 16, 2018
@georgeajit georgeajit assigned georgeajit and unassigned georgeajit Nov 16, 2018
@georgeajit
Copy link
Contributor

Tested develop branch of Java Client API with Open JDK 11 on Linux 3 node MarkLogic cluster running 9.0 nightly server builds (Nov 1 st week builds).

Here are results:

  1. Had to upgrade gradlew to use gradle version ```4.10``. Change needed in wrapper properties file.
  2. Had to update build.gradle to include JAXB runtime library to 2.3.0
    Used this Gradle dependency in marklogic-client-api project:
    compile group: 'org.glassfish.jaxb', name: 'jaxb-runtime', version: '2.3.0'
  3. Minor QA test code changes needed to account for incorrect classloader usage. Need to use application class loader instead of system class loader in ConnectedRESTQA to load test.properties.
  4. ml-development-tools project had one test failure. Refer to DescribedBundleTest from tools project fails with OpenJDK 11 due to null classloader #1032.
  5. JaCoCo usage had issues and its plugin usage was commented out. Refer to Usage of JaCoCo plugin causes RuntimeException when tests are to be run from gradle/wrapper #1029 , Move usage of JaCoCo to QA / functional tests project in build.gradle file #1030
  6. Two tests from ```marklogic-client-api project failed when JDK 11 was used. Refer to UnsupportedOperationException thrown from SSLTest when run on openJDK 11 JVM #1033 and dom.ls.LSException is thrown when QueryOptionsManagerTest is run on open JDK 11 #1034
  7. A couple of QA tests were run and loked fine. Will be running entire suite and updating if failures are found.

@georgeajit georgeajit assigned kkanthet and unassigned georgeajit Nov 16, 2018
@georgeajit
Copy link
Contributor

Assigned to Kiran for time being so that right JDK version to be used can be known, after consulting with Product Mangement, DHF teams.

@ehennum ehennum assigned georgeajit and unassigned kkanthet Feb 22, 2019
@ehennum
Copy link
Contributor

ehennum commented Feb 22, 2019

The JDK versions are being clarified as I write.

Based on Ajit's testing and a few fixes that I checked in, I believe develop can compile and run on 8 - 11.

@georgeajit georgeajit added ship and removed verify labels Mar 27, 2019
@georgeajit
Copy link
Contributor

Have setup Jenkins jobs that handle Java 8, open jdk 9, 10, 11 environments. Had to make gradle (wrapper) changes to handle different Java versions.

@heelix
Copy link

heelix commented Mar 29, 2019 via email

@ehennum
Copy link
Contributor

ehennum commented Mar 29, 2019

It makes sense that Java shops migrating off 8 are going straight to 11. Whether most Java shops that are already on 9 or 10 are quickly moving to 11 is less clear.

Our direction for testing is to move to OpenJDK with the premise that it gives us the broadest set of environments.

@heelix
Copy link

heelix commented Apr 2, 2019 via email

@ehennum
Copy link
Contributor

ehennum commented Apr 3, 2019

Subscribing @aroach337 , who will be interested in the preceding comment.

@heelix
Copy link

heelix commented Apr 3, 2019 via email

@ehennum ehennum closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants