Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Corb doesn't run against ML8 #391

Closed
grtjn opened this issue Feb 23, 2015 · 11 comments
Closed

Corb doesn't run against ML8 #391

grtjn opened this issue Feb 23, 2015 · 11 comments
Labels
Milestone

Comments

@grtjn
Copy link
Contributor

grtjn commented Feb 23, 2015

I suspect the XCC 5 jar is a bit too old to run properly against ML8. Seems to work against ML7..

@grtjn grtjn added the bug label Feb 23, 2015
@grtjn grtjn added this to the 1.7.2 milestone Feb 23, 2015
@dmcassel
Copy link
Collaborator

ML5 is due to be end-of-life'd in May, so if there's a jar that works for ML 6-8, we could go with that one.

@paxtonhare
Copy link
Contributor

I'm thinking we might want to yank the jar. Let the user provide their own.

@dmcassel
Copy link
Collaborator

Seems reasonable to me. If Roxy can't find a jar, it would be useful to have a message saying "To use corb, you must download XCC and set the whatever property to the location of the XCC jar file" -- rather than just "jar not found".

@paxtonhare
Copy link
Contributor

Agreed

@grtjn
Copy link
Contributor Author

grtjn commented Feb 24, 2015

You could then argue that the user could provide entire Corb, like it is now expected to provide MLCP itself. Add corb-home and perhaps corb-vmargs. Searching jars would then be done against corb-home, instead of the internal jars location..

@kefo
Copy link

kefo commented Feb 24, 2015

At the risk of asking a naive question, why remove the jar - and corb - altogether instead of exploring the possibility of updating the jars?

I ask because when roxy ships with these types of helper libraries, everything 'just works' and that is a nice experience (especially when you look at ./ml --help and see corb there).

I'm happy to test corb using the XCC version for ML7 against ML7. I could look into testing XCC version 7 against ML6 and ML8 also, but not as easily. Would that help sway this discussion?

@dmcassel
Copy link
Collaborator

The current challenge is that the "just works" part stopped being true with ML8. If there's an XCC lib that works with ML6, 7, and 8, then I think it is nice to include the jar.

@paxtonhare
Copy link
Contributor

We could look in to magically downloading the right jar depending your ml
version.

Another reason to ditch the file is to reduce download size.

Conversely, I know of a few cases where orgs have to sign off on all
software installed. Getting corb as part of the install is one less
approval step for them to go through. @sparnell, do you have any input on
that?

@grtjn
Copy link
Contributor Author

grtjn commented Feb 26, 2015

Easier fix, looks like Corb runs just fine with marklogic-xcc-8.0-1.jar against latest ML5. I'll trade out that jar..

@grtjn
Copy link
Contributor Author

grtjn commented Feb 26, 2015

By the way, anyone got a clue which version of Corb we are shipping? (And for that matter, how about the other jars?)

paxtonhare added a commit that referenced this issue Mar 10, 2015
Fixed #391: replaced xcc jar, improved jar lookup
@paxtonhare
Copy link
Contributor

fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants