This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Issue #521: improved support for Corb2 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusted the regex to add an additional matching group, and ensure that .upcase is only applied to the CoRB option name, and not the custom input.
|
Thanks, looks pretty clean. Also thanks for upgrading the corb jar. I'll try to run a quick test later today, looking forward to it.. |
|
The new jar gives an elaborate usage when running Not sure how to test the other change, but it is such minimal, and it looked correct, so merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adjusted the regex to add an additional match group and ensure that
.upcaseis only applied to the base option name and not the custom input. This will ensure that custom inputs are applied properly when specified on the commandline.Also, updated to the newly released CoRB2 v2.3.2 with improved usage messages. #521