-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure to allow root entry and correct sub directory entry paths #2
Conversation
fix public path at the entry point main.js file for each entry
@markmarijnissen any progress on review? Not a problem if you are too busy, just was wondering. |
Restructure to allow root entry and correct sub directory entry paths
Hi @talves - I only quickly read through the code changes - I did not actually test it. Considering that I'm short on time, your pull request is well documented, and you actually tested it already on four apps of your own, I've decided to make you a collaborator. The Pull Request in in line with the current philosophy; i.e. support multiple bundles. (For prototyping, tests, back-ends, websites, etc). To sum up my philosophy in one line:
The config itself should stay short and easy, and additional functionality should come in the form of webpack loaders or plugins. @everybody: |
@markmarijnissen thanks Mark, of course I will help out as needed. Funny, there was an |
We can now have a root entry point at the same time as having a sub directory entry points.
Here are the highlights of the changes
webpack-dev-server
webpack
build into/dist
Notes:
I believe there should be a fix to the file-loader as in my fork here talves/file-loader to make sure url paths end up in a more direct relative path to the index.html entry point. (i.e. images/... vs ../boilerplate/images/...) by using the root context (context + /boilerplate) to resolve the url path.
The change is not required, but allows us to have a stand alone entry path without having to be dependent on the public path being set in the resource file in the file loader.
In the current solution, we will not be able to export a module to just any path if we do not use the new file-loader changes.