Allow per-bubble overrides for fillOpacity #89 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return datum.borderColor || options.borderColor; | ||
| }) | ||
| .style('stroke-width', function ( datum ) { | ||
| return datum.borderWidth || options.borderWidth; |
There was a problem hiding this comment.
The only issue with these 2 are if datum.borderColor or datum.borderWidth are set to 0, this will return the options version of it, which isn't right.
It should be expanded to see if it's defined first (like typeof datum.borderWidth !== 'undefined' ? datum.borderWidth : options.borderWidth or something)
|
Yep, good catch, this patch should take care of that. Thanks. |
markmarkoh
added a commit
that referenced
this pull request
Jun 2, 2014
Allow per-bubble overrides for fillOpacity #89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.