IE11 fix, for mouse hovers. Changed /MSIE/ to /((MSIE)|(Trident))/ #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wesww, merging this. Fixes #35 as well. Sorry @paulovpereira, you deserve credit for this one too. |
markmarkoh
added a commit
that referenced
this pull request
Jun 4, 2014
IE11 fix, for mouse hovers. Changed /MSIE/ to /((MSIE)|(Trident))/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a build and the fix looks good.
This is basically an alternate, current version of this thread:
https://github.com/markmarkoh/datamaps/pull/35/files
Looks like a couple of lines related to border colors changed as well, guess the source must have been changed recently since I didn't touch that code in the source file. I tested the setting border options using the built files like that and they still work perfectly so no worries