Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include French Guiana in France's coordinates #97

Merged
merged 1 commit into from
Jun 11, 2014

Conversation

joannecheng
Copy link
Contributor

When we select France in the choropleth world map, French Guiana gets included (see the Northeast corner of South America).

datamaps

I removed the coordinates for French Guiana from the France feature in world.json, created a new feature for French Guiana, ran topojson world.json -o world.topo.json, then ran grunt build. Please let me know if I missed anything or need to do anything else to make this PR merge-able.

@markmarkoh
Copy link
Owner

This looks great @joannecheng, thanks for fixing this. The only issue with with the topojson command, by default topojson drops all properties but we actually want to carry over a property.

I have to add a 'Contribution' section to the README, but for now the topojson command should look more like:

topojson --id-property iso_a3 -p name=name_long -p name -o world.topo.json world.json

@joannecheng
Copy link
Contributor Author

@markmarkoh Done! Updated all the files with the output from the fixed topojson command.

markmarkoh added a commit that referenced this pull request Jun 11, 2014
Don't include French Guiana in France's coordinates
@markmarkoh markmarkoh merged commit 572eac8 into markmarkoh:master Jun 11, 2014
@markmarkoh
Copy link
Owner

Thanks @joannecheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants