Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scriptlet block with semi-colon #148

Merged
merged 1 commit into from Feb 7, 2023

Conversation

DylanPiercey
Copy link
Contributor

Fix issue with semi-colon after a block scriptlet.

eg

$ {
  console.log("hi");
};

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

🦋 Changeset detected

Latest commit: f6bf714

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 93.23% // Head: 93.09% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (f6bf714) compared to base (e864b4b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   93.23%   93.09%   -0.14%     
==========================================
  Files          26       26              
  Lines        1271     1275       +4     
  Branches      287      289       +2     
==========================================
+ Hits         1185     1187       +2     
- Misses         55       57       +2     
  Partials       31       31              
Impacted Files Coverage Δ
src/states/INLINE_SCRIPT.ts 100.00% <100.00%> (ø)
src/core/Parser.ts 91.30% <0.00%> (-1.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 948830e into main Feb 7, 2023
@DylanPiercey DylanPiercey deleted the semi-colon-after-scriptlet-block branch February 7, 2023 21:19
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant