Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure type args directly follow tag name #152

Merged
merged 2 commits into from Feb 25, 2023
Merged

Conversation

DylanPiercey
Copy link
Contributor

Improve handling ambiguity with tag type args vs type params. Type args must now always be directly adjacent the tag name, otherwise it will become type params.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2023

🦋 Changeset detected

Latest commit: c8ecdbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 93.41% // Head: 93.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (c8ecdbe) compared to base (210427c).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   93.41%   93.40%   -0.02%     
==========================================
  Files          26       26              
  Lines        1276     1274       -2     
  Branches      289      288       -1     
==========================================
- Hits         1192     1190       -2     
- Misses         53       54       +1     
+ Partials       31       30       -1     
Impacted Files Coverage Δ
src/states/OPEN_TAG.ts 91.34% <88.88%> (+0.39%) ⬆️
src/states/ATTRIBUTE.ts 94.52% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit ea65c9f into main Feb 25, 2023
@DylanPiercey DylanPiercey deleted the type-args-parsing branch February 25, 2023 23:11
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant