Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid period continuation for non identifier, improve coma sep handling for attrs #154

Merged
merged 2 commits into from Mar 8, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Expression continuations after a period will now only happen if the period is followed by something that could be an identifier (eg a word).
  • Comas after the tag name will now always enter into attribute parsing mode.
  • When in concise mode, a new line that starts with a coma will now continue the attributes for the previous tag.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 00ef6d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (33d280d) 93.40% compared to head (00ef6d6) 93.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   93.40%   93.43%   +0.02%     
==========================================
  Files          26       26              
  Lines        1274     1279       +5     
  Branches      288      291       +3     
==========================================
+ Hits         1190     1195       +5     
  Misses         54       54              
  Partials       30       30              
Impacted Files Coverage Δ
src/states/TAG_NAME.ts 98.24% <ø> (ø)
src/core/Parser.ts 93.52% <100.00%> (+0.04%) ⬆️
src/states/EXPRESSION.ts 93.50% <100.00%> (+0.12%) ⬆️
src/states/OPEN_TAG.ts 91.38% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey force-pushed the avoid-period-continuation-for-non-identifier branch 3 times, most recently from eae935c to 18a51f2 Compare March 8, 2023 04:22
@DylanPiercey DylanPiercey force-pushed the avoid-period-continuation-for-non-identifier branch from 18a51f2 to 00ef6d6 Compare March 8, 2023 04:26
@DylanPiercey DylanPiercey merged commit 6b5b196 into main Mar 8, 2023
@DylanPiercey DylanPiercey deleted the avoid-period-continuation-for-non-identifier branch March 8, 2023 14:26
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant