Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsed text placeholders should enter the text state on close qu… #161

Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

Resolves marko-js/marko#1912

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 6bb6ba4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d8de146) 93.65% compared to head (6bb6ba4) 93.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files          27       27           
  Lines        1293     1294    +1     
  Branches      293      293           
=======================================
+ Hits         1211     1212    +1     
  Misses         53       53           
  Partials       29       29           
Impacted Files Coverage Δ
src/states/PARSED_STRING.ts 90.00% <100.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit be73442 into main Mar 15, 2023
@DylanPiercey DylanPiercey deleted the fix-enter-text-state-after-parsed-text-placeholder branch March 15, 2023 20:26
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marko drops closing quote around value
2 participants