fix: issue with completions around multi choice snippets (#195)

.changeset/forty-days-deliver.md

@@ -0,0 +1,6 @@
+---
+"@marko/language-server": patch
+"marko-vscode": patch
+---
+
+VSCode has a regression which causes all intelisense to break after a completion with a multi choice snippet is provided. The language server currently uses that to provide completions for attributes defined with an `enum` value. To resolve this issue, enum completions are simplified to not provide the choice based completion until this is resolved in vscode or another workaround is found.

packages/language-server/src/service/index.ts

@@ -53,7 +53,6 @@ const service: Plugin = {
     );
   },
   async doComplete(doc, params, cancel) {
-    let isIncomplete = false;
     // TODO: this should handle CompletionList.itemDefaults.
     // If there is a single responding plugin, pass through, otherwise need to apply the defaults to the completion items for the plugin.
 
@@ -70,7 +69,6 @@ const service: Plugin = {
             curItems = cur;
           } else {
             curItems = cur.items;
-            isIncomplete ||= cur.isIncomplete;
           }
 
           for (const item of curItems) {
@@ -91,7 +89,7 @@ const service: Plugin = {
     if (cancel.isCancellationRequested) return;
 
     if (itemsByLabel.size) {
-      return { items: [...itemsByLabel.values()], isIncomplete };
+      return { items: [...itemsByLabel.values()], isIncomplete: true };
     }
   },
   async doCompletionResolve(item, cancel) {

packages/language-server/src/service/marko/complete/AttrName.ts

@@ -81,7 +81,9 @@ export function AttrName({
     let snippet = attr.name;
 
     if (attr.enum) {
-      snippet += `="\${1|${attr.enum.join()}|}"$0`;
+      // TODO: We should use the following, but vscode has a regression with multi choice snippets form the language server.
+      // snippet += `="\${1|${attr.enum.join()}|}"$0`;
+      snippet += `="$1"$0`;
     } else {
       switch (type) {
         case "string":

packages/vscode/src/__tests__/completion.test.ts

@@ -30,7 +30,7 @@ describe("completion", () => {
     await snap.inline(
       () => suggest("<div aria-liv█>"),
       `
-<div aria-live="off">
+<div aria-live="">
 `
     );
   });

packages/vscode/src/index.ts

@@ -33,7 +33,10 @@ export async function activate(ctx: ExtensionContext) {
   // Options to control the language client
   const clientOptions: LanguageClientOptions = {
     // Register the server for marko text documents
-    documentSelector: [{ language: "marko" }],
+    documentSelector: [
+      { scheme: "file", language: "marko" },
+      { scheme: "untitled", language: "marko" },
+    ],
     synchronize: {
       // Synchronize the setting section 'marko' to the server
       configurationSection: "marko",