Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axe-core): reduce number of false positives #221

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

LuLaValva
Copy link
Member

@LuLaValva LuLaValva commented Oct 30, 2023

Description

  • HTML extractor received a very minor update where dynamic${id} changed just to dynamic.
  • The manually separated rules are now in a different format, within the rule-exceptions file. This allows for more freedom with the way that exceptions are specified and I think it's also cleaner.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 433498d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/language-server Patch
@marko/language-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva self-assigned this Nov 16, 2023
@DylanPiercey DylanPiercey merged commit bc8aae9 into main Dec 5, 2023
4 checks passed
@DylanPiercey DylanPiercey deleted the axe-specific-attrs branch December 5, 2023 20:04
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axe-core: current solution for dynamic values produces false positives
2 participants