fix: allow lazy/pending hydration after browser has finished loading (#…

…2250)

.changeset/thirty-lamps-notice.md

@@ -0,0 +1,5 @@
+---
+"marko": patch
+---
+
+Allow registering/loading top level hydrated components _after_ the "load" event. Previously after the load event it was assumed all assets would have been loaded but this is not always accurate for assets loaded through interactions.

packages/marko/src/node_modules/@internal/components-registry/index-browser.js

@@ -53,18 +53,6 @@ function register(type, def) {
 function addPendingDef(def, type, meta, host, runtimeId) {
   if (!pendingDefs) {
     pendingDefs = {};
-
-    // eslint-disable-next-line no-constant-condition
-    if ("MARKO_DEBUG") {
-      document.addEventListener("load", function () {
-        var pendingComponentIds = Object.keys(pendingDefs);
-        if (pendingComponentIds.length) {
-          complain(
-            "Marko templates were never loaded for: " + pendingComponentIds
-          );
-        }
-      });
-    }
   }
   (pendingDefs[type] = pendingDefs[type] || []).push([
     def,
@@ -499,7 +487,6 @@ function initServerRendered(renderedComponents, host) {
       var typeName = meta.___types[componentDef[1]];
 
       return registered[typeName] ||
-        document.readyState === "complete" ||
         req.e(typeName)
         ? tryHydrateComponent(componentDef, meta, host, runtimeId)
         : addPendingDef(componentDef, typeName, meta, host, runtimeId);