Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: components under client-reorder not initializing #1566

Merged
merged 1 commit into from May 4, 2020

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented May 4, 2020

Description

Fixes a regression from #1502 which causes components under a client-reorder not to initialize.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1566 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
+ Coverage   90.54%   90.59%   +0.04%     
==========================================
  Files         355      355              
  Lines       12769    12773       +4     
==========================================
+ Hits        11562    11572      +10     
+ Misses       1207     1201       -6     
Impacted Files Coverage Δ
...rko/src/core-tags/core/await/reorderer-renderer.js 94.87% <100.00%> (+0.58%) ⬆️
...marko/src/compiler/util/convertRawJavaScriptAst.js 87.83% <0.00%> (+0.52%) ⬆️
packages/marko/src/runtime/html/StringWriter.js 96.77% <0.00%> (+16.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f165f0...7dffe29. Read the comment docs.

@DylanPiercey DylanPiercey force-pushed the fix-client-reorder-component-initialization branch from 83b5718 to 7dffe29 Compare May 4, 2020 22:09
@DylanPiercey DylanPiercey merged commit 28b3b7f into master May 4, 2020
@DylanPiercey DylanPiercey deleted the fix-client-reorder-component-initialization branch May 4, 2020 22:20
DylanPiercey added a commit that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant